stevedlawrence commented on a change in pull request #74: Daffodil trailing sep
URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r195060193
##########
File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala
##########
@@ -359,6 +360,25 @@ trait Term
def isKnownRequiredElement = false
def hasKnownRequiredSyntax = false
+ def hasPotentiallyTrailingInstances: Boolean = false
+ final def isPotentiallyTrailing = LV('isPotentiallyTrailing) {
+ if (!isRequired) {
Review comment:
If something isRequired, doesn't that mean it could still be potentially
trailing if eveything after that is optional? So the algorithm should always
just be something like:
1) find that last required element
2) this element is potentially trailing if it is that last required element
or appears after it.
Also, this doesn't take into account this like if the
nearestEnclosingSequence is ordered or or unordered. This also feels very
similar to couldBeLastElementInModelGroup. Are there subtle differences between
what those are asking about?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
