mbeckerle commented on a change in pull request #88: Daffodil 1919 separators
URL: https://github.com/apache/incubator-daffodil/pull/88#discussion_r209000443
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/DFDLEscapeScheme.scala
##########
@@ -68,6 +68,12 @@ final class DFDLEscapeScheme(node: Node, decl:
AnnotatedSchemaComponent, defES:
}
}
+ /**
+ * For unit testing. Must override because of multiple inheritance.
+ */
+ override def verifyPropValue(key: String, value: String): Boolean =
+ super.verifyPropValue(key, value)
+
Review comment:
I tried removing this seeming no-op.
I guess the reason this is here is because the scala compiler complains and
this shuts it up.
And it doesn't complain about other places.
class DFDLEscapeScheme inherits conflicting members: method
verifyPropValue in class DFDLFormatAnnotation of type (propName: String,
expectedValue: String)Boolean and method verifyPropValue in trait
FindPropertyMixin of type (key: String, value: String)Boolean (Note: this can
be resolved by declaring an override in class DFDLEscapeScheme.)
I'm modifying the comment to explain this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
