mbeckerle commented on a change in pull request #88: Daffodil 1919 separators
URL: https://github.com/apache/incubator-daffodil/pull/88#discussion_r209042609
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/SpecifiedLength.scala
##########
@@ -29,21 +29,32 @@ import
org.apache.daffodil.processors.parsers.SpecifiedLengthExplicitParser
import org.apache.daffodil.processors.parsers.SpecifiedLengthImplicitParser
import org.apache.daffodil.dpath.NodeInfo.PrimType
import org.apache.daffodil.processors.parsers.Parser
+import org.apache.daffodil.util.Maybe
+import org.apache.daffodil.util.Maybe._
abstract class SpecifiedLengthCombinatorBase(val e: ElementBase, eGramArg: =>
Gram)
extends Terminal(e, true) {
lazy val eGram = eGramArg // once only
- lazy val eParser = eGram.parser
+
Review comment:
Documented on Gram class/trait now. Got rid of maybeEParser.
Parsers/Unparsers that these parsers are passed to, those take care of the
issue of isEmpty.
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
