mbeckerle commented on a change in pull request #88: Daffodil 1919 separators
URL: https://github.com/apache/incubator-daffodil/pull/88#discussion_r209005800
 
 

 ##########
 File path: 
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ParticleMixin.scala
 ##########
 @@ -41,17 +49,27 @@ trait RequiredOptionalMixin { self: ElementBase =>
           false
         } else {
           max match {
-            case Some(1) => true
-            case None => true
-            case Some(_) => false
+            case 1 => true
+            case _ => false
           }
         }
       }
       case _ => false
     }
   }
 
+  /**
+   * True if the element is required to appear in the DFDL Infoset.
+   *
+   * This includes elements that have no representation in the
+   * data stream. That is, an element with dfdl:inputValueCalc will be 
isRequired true.
+   *
+   * Takes into account that some dfdl:occursCountKind can make
+   * seemingly required elements (based on minOccurs) optional or
+   * repeating.
+   */
   final override def isRequired: Boolean = LV('isRequired) {
+    // TODO: Rename to isRequiredOrComputed
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to