mbeckerle commented on a change in pull request #143: Support
dfdl:length="prefixed"
URL: https://github.com/apache/incubator-daffodil/pull/143#discussion_r239883961
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ElementCombinator.scala
##########
@@ -295,7 +295,7 @@ case class CaptureValueLengthStart(ctxt: ElementBase)
new NadaParser(ctxt.erd)
override lazy val unparser: Unparser =
- if (ctxt.isReferencedByValueLengthUnparserExpressions) {
+ if (ctxt.isReferencedByValueLengthUnparserExpressions ||
ctxt.otherwiseShouldCaptureValueRegionLength) {
Review comment:
Are there other reasons for "otherwiseShouldCapture..." than prefixLength?
Maybe this should just be shouldCaptureForPrefixLength?.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services