mbeckerle commented on a change in pull request #143: Support
dfdl:length="prefixed"
URL: https://github.com/apache/incubator-daffodil/pull/143#discussion_r239892744
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ElementCombinator.scala
##########
@@ -295,7 +295,7 @@ case class CaptureValueLengthStart(ctxt: ElementBase)
new NadaParser(ctxt.erd)
override lazy val unparser: Unparser =
- if (ctxt.isReferencedByValueLengthUnparserExpressions) {
+ if (ctxt.isReferencedByValueLengthUnparserExpressions ||
ctxt.otherwiseShouldCaptureValueRegionLength) {
Review comment:
Just a suggestion that all the reasons for why one might lay down the
"capture" things in the grammar should either be centralized (here), or
distributed in some way. We are halfway between with one case (used in an
expression) explicitly mentioned here, the others abstracted away in an
"otherwise" method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services