mbeckerle commented on a change in pull request #143: Support 
dfdl:length="prefixed"
URL: https://github.com/apache/incubator-daffodil/pull/143#discussion_r239886147
 
 

 ##########
 File path: 
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/BinaryNumberTraits.scala
 ##########
 @@ -50,3 +56,63 @@ trait HasRuntimeExplicitLength {
     nBytes * toBits
   }
 }
+
+
+trait PrefixedLengthParserMixin {
+
+  def prefixedLengthParser: Parser
+  def prefixedLengthERD: ElementRuntimeData
+  def lengthUnits: LengthUnits
+  def prefixedLengthAdjustmentInUnits: Long
 
 Review comment:
   Don't think this can be a Long. I think it has to be an Evaluatable[Long], 
since the prefix length field itself can be variable length determined at 
runtime. 
   
   I'm ok with putting that off to a future change. A useful comment about this 
limitation then would be all. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to