stevedlawrence commented on a change in pull request #214: Sequences and
Separators Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285212033
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/ProcessorResult.scala
##########
@@ -23,11 +23,19 @@ import org.apache.daffodil.api.Diagnostic
/**
* The resulting state after invoking a Processor
*/
-sealed abstract class ProcessorResult;
+sealed abstract class ProcessorResult {
+ def isSuccess: Boolean
+ def isFailure: Boolean
Review comment:
Do we really need both isSuccess and isFailure? I assume one is always the
negation of the other? I'd rather only have one, but if you want both for
readability can we make one a final and it returns the negation of the other?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
