stevedlawrence commented on a change in pull request #214: Sequences and
Separators Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285211325
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/InfosetImpl.scala
##########
@@ -1409,6 +1431,18 @@ sealed class DIComplex(override val erd:
ElementRuntimeData, val tunable: Daffod
e.setParent(this)
}
+ def maybeMostRecentlyAddedChild(): Maybe[DIElement] = {
Review comment:
Doesn't seem unreasonable to me. Some other options might be to store the
last child of each complex (seems unnecessary since it isn't always needed) or
for the parse of the child to calculate and return the parse attempt status
(which I'm not sure the child has all the information, and again I'm not sure
it's even needed all the time). This seems fine, and is going to be plenty
performant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
