stevedlawrence commented on a change in pull request #214: Sequences and
Separators Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285229129
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SequenceChildBases.scala
##########
@@ -325,35 +408,33 @@ object ArrayIndexStatus {
* fail on a zero-length string. This is used in some situations where we
* tolerate redundant separators.
*/
- case object OptionalLast extends OptionalArrayIndexStatus
-
- /**
- * Indicates that pstate status is failed, that is, we
- * are unable to continue parsing. No parse attempt should be done for this
- * index.
- */
- case object Failed extends StopArrayIndexStatus
-
- /**
- * Indicates that we are done iterating, and should stop parsing more
- * array. Used to indicate that the end of the array was identified
- * by speculative parsing.
- */
- case object Done extends StopArrayIndexStatus
+ case object OptionalLast extends Type with RequiredOptionalStatus.Optional
+
+ // /**
+ // * Indicates that the parsing of an element occurence for that index
should
+ // * not be attempted.
+ // */
+ // sealed trait StopArrayIndexStatus extends ArrayIndexStatus
+ // /**
+ // * Indicates that pstate status is failed, that is, we
+ // * are unable to continue parsing. No parse attempt should be done for
this
+ // * index.
+ // */
+ // case object Failed extends StopArrayIndexStatus
+ //
Review comment:
Can these be removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
