stevedlawrence commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285114984
########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala ########## @@ -94,8 +94,7 @@ trait ChoiceDefMixin } } -abstract class ChoiceTermBase( - final override val xml: Node, +abstract class ChoiceTermBase(final override val xml: Node, Review comment: Would be nice to figure out the eclipse setting to prevent this in the future. I believe the original formatting is the scala standard, and it makes reviewing easier when there's less having to think about if a change is just formatting or not. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
