stevedlawrence commented on a change in pull request #214: Sequences and
Separators Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285118171
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala
##########
@@ -431,7 +431,7 @@ trait ElementBase
if (isDefaultable && (isScalar ||
isArraywithAtLeastOneRequiredArrayElement)) {
val dv =
if (isNillable && useNilForDefault =:= YesNo.Yes) {
- UseNilForDefault // singleton object indicator
+ Some(UseNilForDefault) // singleton object indicator
Review comment:
This seems odd, and probably needs some documentation. I think this means
``defaultValue`` is either ``None``, ``Some(primTypeValue)``, or
``Some(Some(UseNilForDefault))``. Maybe we need a different way to represent
this? This type is basically an ``Option[AnyRef]``, which isn't very helpful,
and returning Some(UseNilForDefault) doesn't seem that much more helpful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
