stevedlawrence commented on a change in pull request #214: Sequences and
Separators Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285119232
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala
##########
@@ -769,6 +773,9 @@ trait ElementBase
}
final def hasFixedLengthOf(n: Int) = {
+ // FIXME: needs to work in lengthUnits. If length units is bytes/bits
+ // and encoding is variable-width charset, what should this return?
+ // (Perhaps should be usage error?)
Review comment:
Should we create bugs for all the se FIXME's?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
