stevedlawrence commented on a change in pull request #218: Implement
dfdl:choiceLength='explicit'
URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r286260304
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SpecifiedLengthParsers.scala
##########
@@ -132,6 +133,18 @@ class SpecifiedLengthExplicitParser(
}
}
+class SpecifiedLengthChoiceParser(
+ eParser: Parser,
+ erd: RuntimeData,
+ choiceLength: JLong,
+ toBits: Int)
+ extends SpecifiedLengthParserBase(eParser, erd) {
Review comment:
Remove toBits and change choiceLength to chocieLengthInBits, or is toBits
needed by SpecifiedLengthParserBase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
