stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r286254101
########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/SpecifiedLength2.scala ########## @@ -444,7 +447,7 @@ class ElementUnusedUnparserSuspendableOperation( } class ElementUnusedUnparser( - override val context: ElementRuntimeData, + override val context: TermRuntimeData, Review comment: Can these TermRuntimeData changes be reverted? I think they were changed back when you were tyring to share evaluatables, but maybe it's not necessary now? It seems more correct for an Element*Parser to have ElementRuntimeData. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
