stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r286254381
########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/SpecifiedLength2.scala ########## @@ -460,6 +463,64 @@ class ElementUnusedUnparser( } +/** + * This is basically a simplified version of the ElementUnusedUnparserSuspendableOperation. + * For explicit length choices, we do not need to handle length expressions, choiceLength is + * simply a non-negative integer. + */ +class ChoiceUnusedUnparserSuspendableOperation( + override val rd: TermRuntimeData, Review comment: Can this be ChoiceRuntimeData? I think the context for this will always be a choice? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
