mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp
simple types
URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289568013
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala
##########
@@ -69,7 +70,7 @@ trait SchemaComponent
schemaFileLocation,
tunable)
- val context: SchemaComponent = parent
+ val context: SchemaComponent = lexicalParent
Review comment:
Rename to lexicalContext. Equally weak name as "parent".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
