mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp
simple types
URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289834437
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala
##########
@@ -54,11 +54,12 @@ trait SchemaComponent
with PropTypes {
def xml: Node
- def parent: SchemaComponent
+ def lexicalParent: SchemaComponent
+ final lazy val optLexicalParent = Option(lexicalParent)
- final override def oolagContextViaArgs = Some(parent)
+ override def oolagContextViaArgs = Option(lexicalParent)
Review comment:
I will be pushing a new PR later that gets rid of the null/non-null for
parents entirely. I'm sick of getting NPEs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
