mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp
simple types
URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289833328
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ModelGroup.scala
##########
@@ -250,8 +250,8 @@ abstract class ModelGroup(index: Int)
case eb: ElementBase => !eb.isRequiredInInfoset ||
!eb.isRepresented
}
if (lastIsOptional) {
- val (priorSibs, parent) = last.potentialPriorTerms
- (last +: priorSibs, parent.isDefined)
+ val (priorSibs, optPriorParent) = last.potentialPriorTerms
Review comment:
Unfortunately, this is not the lexical parent. This is still code depending
on backrefs to dynamic enclosing parents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
