The XML comments was definitely part of it. Found that one and fixed it with the override def comment(..) as you suggest.
There are still other tests failing though. I have been spinning up a windows dev environment and I noticed that the comments contain CRLFs on windows, and likely due to autoCRLF stuff, do not on Linux. Where do I find this autoCRLF setting? The .gitconfig in my linux home doesn't have an autocrlf setting. And I am not finding one on Windows, though not sure entirely where that would live on Windows. ________________________________ From: Steve Lawrence <slawre...@apache.org> Sent: Tuesday, May 18, 2021 11:57 AM To: dev@daffodil.apache.org <dev@daffodil.apache.org> Subject: Re: Windows debug clues needed Finished the review and I didn't find anything, but I just noticed that some of the failed TMDL tests have infosets that include comments, that include newlines. I'm guessing these comments aren't stripped out by the loader and also aren't normalized. So when git autocrlf kicks in, it changes these comments to have \r\n, we don't normalize that, and the the infoset does contain \r's and we error. It looks like the ConstructingParser has a 'def comment' function, so maybe we just need to override that to normalize the comment contents? - Steve On 5/18/21 8:58 AM, Beckerle, Mike wrote: > My PR https://github.com/apache/daffodil/pull/560 > <https://github.com/apache/daffodil/pull/560> > > Keeps failing its tests on MS-Windows. > > I am unable to reproduce the failures on Linux obviously. > > But... I am also unable to reproduce these failures on MS-Windows. > > I have installed sbt, git, intellij idea, emacs, etc. all on MS-Windows. When > I > run the tests via sbt test... they all pass. > > So one possibility is that I have git configured differently (w.r.t the > autocrlf > stuff) than is done by the windows CI systems. > > Suggestions? > > > > > Mike Beckerle | Principal Engineer > > mbecke...@owlcyberdefense.com <mailto:bhum...@owlcyberdefense.com> > > P +1-781-330-0412 >
