leerho commented on PR #689: URL: https://github.com/apache/datasketches-java/pull/689#issuecomment-3404092803
I am about to leave for an extended vacation in a few days and I need to focus on getting ready for this long trip. So I need to pause my refactoring until I get back on Nov 5th. I have completed, I think, all the necessary name changes for /theta/ and /tuple/ … and that is quite a lot, 124 files for just those two families! Bear in mind that there are no code logic changes whatsoever. But of course, the name changes constitute breaking changes on their own. All the unit tests run just fine, even the CI tests. I primarily focused on the public classes where: There was overlap of classes with the same name between /theta/ and /tuple/. Where there might be reasons to want to import the same named class from /theta/ and from /tuple/ within the same user class. I did not attempt to rename the many public classes where the name was already unique and it was not duplicated in any other family. I felt that those were easy to understand what family they belonged to by their context. Nonetheless, CoPilot complains about the fact that the deprecated methods are still used in test, and still have a few transient references in main that a are unavoidable — unless we remove all of the deprecated methods, which I don’t have the energy or desire to do for this release. I will not be able to check on this PR while I’m gone, but I will be grateful if someone could approve it, and merge it in the meantime. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
