github-advanced-security[bot] commented on code in PR #689:
URL: https://github.com/apache/datasketches-java/pull/689#discussion_r2418246503
##########
src/test/java/org/apache/datasketches/theta/DirectIntersectionTest.java:
##########
@@ -374,55 +374,55 @@
public void checkOverflow() {
final int lgK = 9; //512
final int k = 1<<lgK;
- Intersection inter;
- UpdateSketch sk1;
- final UpdateSketch sk2;
- final CompactSketch comp1;
+ ThetaIntersection inter;
+ UpdatableThetaSketch sk1;
+ final UpdatableThetaSketch sk2;
Review Comment:
## Unread local variable
Variable 'UpdatableThetaSketch sk2' is never read.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/906)
##########
src/test/java/org/apache/datasketches/theta/UpdateSketchTest.java:
##########
@@ -209,9 +209,9 @@
@Test
public void checkCompactOpsMemorySegmentToCompact() {
MemorySegment skwseg, cskwseg1, cskwseg2, cskwseg3;
- CompactSketch csk1, csk2, csk3;
+ CompactThetaSketch csk1, csk2, csk3;
Review Comment:
## Unread local variable
Variable 'CompactThetaSketch csk3' is never read.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/911)
##########
src/test/java/org/apache/datasketches/theta/HeapAlphaSketchTest.java:
##########
@@ -666,21 +666,21 @@
@Test
public void checkFamily() {
- UpdateSketch sketch = UpdateSketch.builder().setFamily(ALPHA).build();
+ UpdatableThetaSketch sketch =
UpdatableThetaSketch.builder().setFamily(ALPHA).build();
assertEquals(sketch.getFamily(), Family.ALPHA);
}
@SuppressWarnings("unused")
@Test(expectedExceptions = SketchesArgumentException.class)
public void corruptionLgNomLongs() {
final int k = 512;
- UpdateSketch sketch = UpdateSketch.builder().setNominalEntries(k)
+ UpdatableThetaSketch sketch =
UpdatableThetaSketch.builder().setNominalEntries(k)
.setFamily(ALPHA).build();
for (int i = 0; i < k; i++) { sketch.update(i); }
byte[] byteArr = sketch.toByteArray();
MemorySegment wseg = MemorySegment.ofArray(byteArr);
wseg.set(JAVA_BYTE, LG_NOM_LONGS_BYTE, (byte) 8); //corrupt LgNomLongs
- UpdateSketch sk = UpdateSketch.heapify(wseg);
+ UpdatableThetaSketch sk = UpdatableThetaSketch.heapify(wseg);
Review Comment:
## Unread local variable
Variable 'UpdatableThetaSketch sk' is never read.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/908)
##########
src/test/java/org/apache/datasketches/theta/UpdateSketchTest.java:
##########
@@ -209,9 +209,9 @@
@Test
public void checkCompactOpsMemorySegmentToCompact() {
MemorySegment skwseg, cskwseg1, cskwseg2, cskwseg3;
- CompactSketch csk1, csk2, csk3;
+ CompactThetaSketch csk1, csk2, csk3;
Review Comment:
## Unread local variable
Variable 'CompactThetaSketch csk2' is never read.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/910)
##########
src/test/java/org/apache/datasketches/theta/DirectIntersectionTest.java:
##########
@@ -374,55 +374,55 @@
public void checkOverflow() {
final int lgK = 9; //512
final int k = 1<<lgK;
- Intersection inter;
- UpdateSketch sk1;
- final UpdateSketch sk2;
- final CompactSketch comp1;
+ ThetaIntersection inter;
+ UpdatableThetaSketch sk1;
+ final UpdatableThetaSketch sk2;
+ final CompactThetaSketch comp1;
Review Comment:
## Unread local variable
Variable 'CompactThetaSketch comp1' is never read.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/907)
##########
src/test/java/org/apache/datasketches/theta/UpdateSketchTest.java:
##########
@@ -209,9 +209,9 @@
@Test
public void checkCompactOpsMemorySegmentToCompact() {
MemorySegment skwseg, cskwseg1, cskwseg2, cskwseg3;
- CompactSketch csk1, csk2, csk3;
+ CompactThetaSketch csk1, csk2, csk3;
Review Comment:
## Unread local variable
Variable 'CompactThetaSketch csk1' is never read.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/909)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
