github-advanced-security[bot] commented on code in PR #689:
URL: https://github.com/apache/datasketches-java/pull/689#discussion_r2430752584
##########
src/main/java/org/apache/datasketches/tuple/TupleSketch.java:
##########
@@ -221,4 +226,46 @@
return sb.toString();
}
+ /**
+ * Instantiate an UpdatableTupleSketch from a given MemorySegment on the
heap,
+ * @param <U> Type of update value
+ * @param <S> Type of Summary
+ * @param seg MemorySegment object representing an UpdatableTupleSketch
+ * @param deserializer instance of SummaryDeserializer
+ * @param summaryFactory instance of SummaryFactory
+ * @return UpdatableTupleSketch created from its MemorySegment representation
+ */
+ public static <U, S extends UpdatableSummary<U>> UpdatableTupleSketch<U, S>
heapifyUpdatableSketch(
+ final MemorySegment seg,
+ final SummaryDeserializer<S> deserializer,
+ final SummaryFactory<S> summaryFactory) {
+ return new UpdatableTupleSketch<>(seg, deserializer, summaryFactory);
+ }
+
+ /**
+ * Instantiate a TupleSketch from a given MemorySegment.
+ * @param <S> Type of Summary
+ * @param seg MemorySegment object representing a TupleSketch
+ * @param deserializer instance of SummaryDeserializer
+ * @return TupleSketch created from its MemorySegment representation
+ */
+ public static <S extends Summary> TupleSketch<S> heapifySketch(
+ final MemorySegment seg,
+ final SummaryDeserializer<S> deserializer) {
+ final SerializerDeserializer.SketchType sketchType =
SerializerDeserializer.getSketchType(seg);
+ if (sketchType == SerializerDeserializer.SketchType.QuickSelectSketch) {
+ return new QuickSelectSketch<>(seg, deserializer, null);
Review Comment:
## Deprecated method or constructor invocation
Invoking [QuickSelectSketch.QuickSelectSketch](1) should be avoided because
it has been deprecated.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/913)
##########
src/test/java/org/apache/datasketches/tuple/adouble/AdoubleTest.java:
##########
@@ -73,14 +72,14 @@
public void serDeTest() {
final int lgK = 12;
final int K = 1 << lgK;
- final DoubleSketch a1Sk = new DoubleSketch(lgK, Mode.AlwaysOne);
+ final DoubleTupleSketch a1Sk = new DoubleTupleSketch(lgK, Mode.AlwaysOne);
final int m = 2 * K;
for (int key = 0; key < m; key++) {
a1Sk.update(key, 1.0);
}
final double est1 = a1Sk.getEstimate();
final MemorySegment seg = MemorySegment.ofArray(a1Sk.toByteArray());
- final DoubleSketch a1Sk2 = new DoubleSketch(seg, Mode.AlwaysOne);
+ final DoubleTupleSketch a1Sk2 = new DoubleTupleSketch(seg, Mode.AlwaysOne);
Review Comment:
## Deprecated method or constructor invocation
Invoking [DoubleTupleSketch.DoubleTupleSketch](1) should be avoided because
it has been deprecated.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/914)
##########
src/test/java/org/apache/datasketches/tuple/aninteger/IntegerSketchTest.java:
##########
@@ -42,14 +39,14 @@
final int lgK = 12;
final int K = 1 << lgK;
final IntegerSummary.Mode a1Mode = IntegerSummary.Mode.AlwaysOne;
- final IntegerSketch a1Sk = new IntegerSketch(lgK, a1Mode);
+ final IntegerTupleSketch a1Sk = new IntegerTupleSketch(lgK, a1Mode);
final int m = 2 * K;
for (int i = 0; i < m; i++) {
a1Sk.update(i, 1);
}
final double est1 = a1Sk.getEstimate();
final MemorySegment seg = MemorySegment.ofArray(a1Sk.toByteArray());
- final IntegerSketch a1Sk2 = new IntegerSketch(seg, a1Mode);
+ final IntegerTupleSketch a1Sk2 = new IntegerTupleSketch(seg, a1Mode);
Review Comment:
## Deprecated method or constructor invocation
Invoking [IntegerTupleSketch.IntegerTupleSketch](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/915)
##########
src/main/java/org/apache/datasketches/tuple/TupleSketch.java:
##########
@@ -221,4 +226,46 @@
return sb.toString();
}
+ /**
+ * Instantiate an UpdatableTupleSketch from a given MemorySegment on the
heap,
+ * @param <U> Type of update value
+ * @param <S> Type of Summary
+ * @param seg MemorySegment object representing an UpdatableTupleSketch
+ * @param deserializer instance of SummaryDeserializer
+ * @param summaryFactory instance of SummaryFactory
+ * @return UpdatableTupleSketch created from its MemorySegment representation
+ */
+ public static <U, S extends UpdatableSummary<U>> UpdatableTupleSketch<U, S>
heapifyUpdatableSketch(
+ final MemorySegment seg,
+ final SummaryDeserializer<S> deserializer,
+ final SummaryFactory<S> summaryFactory) {
+ return new UpdatableTupleSketch<>(seg, deserializer, summaryFactory);
Review Comment:
## Deprecated method or constructor invocation
Invoking [UpdatableTupleSketch.UpdatableTupleSketch](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/912)
##########
src/test/java/org/apache/datasketches/tuple/strings/ArrayOfStringsSketchTest.java:
##########
@@ -53,36 +53,36 @@
printSummaries(sketch1.iterator());
byte[] array = sketch1.toByteArray();
MemorySegment wseg = MemorySegment.ofArray(array);
- ArrayOfStringsSketch sketch2 = new ArrayOfStringsSketch(wseg);
+ ArrayOfStringsTupleSketch sketch2 = new ArrayOfStringsTupleSketch(wseg);
Review Comment:
## Deprecated method or constructor invocation
Invoking [ArrayOfStringsTupleSketch.ArrayOfStringsTupleSketch](1) should be
avoided because it has been deprecated.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/916)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
