notfilippo commented on code in PR #1: URL: https://github.com/apache/datasketches-rust/pull/1#discussion_r2609786295
########## tests/hll_serialization_test.rs: ########## @@ -0,0 +1,230 @@ +//! HLL Sketch Serialization Compatibility Tests +//! +//! These tests verify binary compatibility with Apache DataSketches implementations: +//! - Java (datasketches-java) +//! - C++ (datasketches-cpp) +//! - Go (datasketches-go) +//! +//! Test data is generated by the reference implementations and stored in: +//! `tests/datasketches-go/serialization_test_data/` + +use std::fs; +use std::path::PathBuf; + +use datasketches::hll::sketch::HllSketch; Review Comment: Similar comment to the above. > ``` > use datasketches::HllSketch; > ```` I agree it looks better like so ########## tests/hll_serialization_test.rs: ########## @@ -0,0 +1,230 @@ +//! HLL Sketch Serialization Compatibility Tests +//! +//! These tests verify binary compatibility with Apache DataSketches implementations: +//! - Java (datasketches-java) +//! - C++ (datasketches-cpp) +//! - Go (datasketches-go) +//! +//! Test data is generated by the reference implementations and stored in: +//! `tests/datasketches-go/serialization_test_data/` + +use std::fs; +use std::path::PathBuf; + +use datasketches::hll::sketch::HllSketch; Review Comment: Similar comment to the above. > ``` > use datasketches::HllSketch; > ```` I agree it looks better like so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
