tisonkun commented on code in PR #1: URL: https://github.com/apache/datasketches-rust/pull/1#discussion_r2616330191
########## tests/serialization_test_data/cpp_generated_files/frequent_long_n0_cpp.sk: ########## Review Comment: ASF generally disallows checking in binary files in the source release. Can we generate these files in CI, or only when we need them? At least we should be clear about how we get these binary files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
