notfilippo commented on code in PR #1: URL: https://github.com/apache/datasketches-rust/pull/1#discussion_r2609795495
########## .gitmodules: ########## @@ -0,0 +1,3 @@ +[submodule "tests/datasketches-go"] Review Comment: `datasketches-go` checks-in the generated testdata for both C++ and Java here: https://github.com/apache/datasketches-go/tree/main/serialization_test_data, so with this submodule I'm actually testing all 3 implementations. Regarding the use of the submodule in general, I agree. Maybe there is space for creating a separate repo just containing serialized samples from well-tested libraries. But I would absolutely check these files in the repo to make sure `cargo test` picks them up without the need to do it only in CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
