notfilippo commented on code in PR #1: URL: https://github.com/apache/datasketches-rust/pull/1#discussion_r2616334002
########## tests/serialization_test_data/cpp_generated_files/frequent_long_n0_cpp.sk: ########## Review Comment: I think it makes sense; I would love for `cargo test` to run the ser/de tests as well so deleting them completely is not a good option. I previously included them as submodules from datasketches-go (https://github.com/apache/datasketches-go/tree/main/serialization_test_data, they are checked in directly in the repo), but @Xuanwo suggested against this. ########## tests/serialization_test_data/cpp_generated_files/frequent_long_n0_cpp.sk: ########## Review Comment: I think it makes sense; I would love for `cargo test` to run the ser/de tests as well so deleting them completely is not a good option. I previously included them as submodules from datasketches-go (https://github.com/apache/datasketches-go/tree/main/serialization_test_data, they are checked in directly in the repo), but @Xuanwo suggested against this and asked me to include them directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
