tisonkun commented on code in PR #44: URL: https://github.com/apache/datasketches-rust/pull/44#discussion_r2651039989
########## datasketches/src/frequencies/mod.rs: ########## @@ -15,13 +15,18 @@ // specific language governing permissions and limitations // under the License. -//! Count-Min sketch implementation for frequency estimation. -//! -//! The Count-Min sketch provides approximate frequency counts for streaming data -//! with configurable relative error and confidence bounds. +//! Frequency sketches for finding heavy hitters in data streams. +mod reverse_purge_item_hash_map; mod serialization; - mod sketch; -pub use self::sketch::CountMinSketch; -pub use self::sketch::DEFAULT_SEED; + +pub mod serde; + +pub use serde::I64Serde; +pub use serde::ItemsSerde; +pub use serde::StringSerde; + +pub use self::sketch::ErrorType; +pub use self::sketch::FrequentItemsSketch; +pub use self::sketch::Row; Review Comment: ```suggestion mod reverse_purge_item_hash_map; mod serialization; mod serde; mod sketch; pub use self::serde::I64Serde; pub use self::serde::ItemsSerde; pub use self::serde::StringSerde; pub use self::sketch::ErrorType; pub use self::sketch::FrequentItemsSketch; pub use self::sketch::Row; ``` Follow the same pattern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
