tisonkun commented on code in PR #44: URL: https://github.com/apache/datasketches-rust/pull/44#discussion_r2651045276
########## datasketches/src/frequencies/sketch.rs: ########## @@ -0,0 +1,408 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Frequent items sketch implementations. + +use std::hash::Hash; + +use crate::error::SerdeError; +use crate::frequencies::reverse_purge_item_hash_map::ReversePurgeItemHashMap; +use crate::frequencies::serde::ItemsSerde; +use crate::frequencies::serialization::*; + +const LG_MIN_MAP_SIZE: u8 = 3; +const SAMPLE_SIZE: usize = 1024; +const EPSILON_FACTOR: f64 = 3.5; +const LOAD_FACTOR_NUMERATOR: usize = 3; +const LOAD_FACTOR_DENOMINATOR: usize = 4; + +/// Error guarantees for frequent item queries. +#[derive(Debug, Clone, Copy, PartialEq, Eq)] +pub enum ErrorType { + /// Include items if upper bound exceeds threshold (no false negatives). + NoFalseNegatives, + /// Include items if lower bound exceeds threshold (no false positives). + NoFalsePositives, +} + +/// Result row for frequent item queries. +#[derive(Debug, Clone, PartialEq, Eq)] +pub struct Row<T> { + item: T, + estimate: i64, + upper_bound: i64, + lower_bound: i64, +} + +impl<T> Row<T> { + /// Returns the item value. + pub fn item(&self) -> &T { + &self.item + } + + /// Returns the estimated frequency. + pub fn estimate(&self) -> i64 { + self.estimate + } + + /// Returns the upper bound for the frequency. + pub fn upper_bound(&self) -> i64 { + self.upper_bound + } + + /// Returns the lower bound for the frequency. + pub fn lower_bound(&self) -> i64 { + self.lower_bound + } +} + +/// Frequent items sketch for generic item types. +#[derive(Debug, Clone)] +pub struct FrequentItemsSketch<T> { + lg_max_map_size: u8, + cur_map_cap: usize, + offset: i64, + stream_weight: i64, + sample_size: usize, + hash_map: ReversePurgeItemHashMap<T>, +} + +impl<T: Eq + Hash> FrequentItemsSketch<T> { + /// Creates a new sketch with the given maximum map size (power of two). + pub fn new(max_map_size: usize) -> Self { + let lg_max_map_size = exact_log2(max_map_size); + Self::with_lg_map_sizes(lg_max_map_size, LG_MIN_MAP_SIZE) + } + + /// Returns true if the sketch is empty. + pub fn is_empty(&self) -> bool { + self.hash_map.get_num_active() == 0 + } + + /// Returns the number of active items being tracked. + pub fn get_num_active_items(&self) -> usize { Review Comment: ```suggestion pub fn num_active_items(&self) -> usize { ``` Ditto others. We use this flavor in both TDigest and HllSketch. Typically, in Rust, when the semantics are clear, we don't use the `get_` prefix but prefer an attribute-style naming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
