tisonkun commented on code in PR #44: URL: https://github.com/apache/datasketches-rust/pull/44#discussion_r2651041108
########## datasketches/src/frequencies/reverse_purge_item_hash_map.rs: ########## @@ -0,0 +1,294 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Reverse purge hash map for generic items. + +use std::hash::Hash; +use std::hash::Hasher; + +use crate::hash::MurmurHash3X64128; + +const LOAD_FACTOR: f64 = 0.75; +const DRIFT_LIMIT: usize = 1024; +const MAX_SAMPLE_SIZE: usize = 1024; + +#[derive(Debug, Clone)] +pub struct ReversePurgeItemHashMap<T> { Review Comment: ```suggestion pub(super) struct ReversePurgeItemHashMap<T> { ``` So we're sure it's not unused outside the crate (module) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
