tisonkun commented on code in PR #51:
URL: https://github.com/apache/datasketches-rust/pull/51#discussion_r2654652501
##########
datasketches/src/frequencies/reverse_purge_item_hash_map.rs:
##########
@@ -118,16 +118,16 @@ impl<T: Eq + Hash> ReversePurgeItemHashMap<T> {
/// Shifts all values by `adjust_amount`.
///
/// This is used during purges to decrement counters.
- pub fn adjust_all_values_by(&mut self, adjust_amount: i64) {
Review Comment:
Revoke `pub` when it's only used in the same file. Less publicity, easier
reasoning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
