tisonkun commented on code in PR #51: URL: https://github.com/apache/datasketches-rust/pull/51#discussion_r2654654273
########## datasketches/src/theta/mod.rs: ########## @@ -32,4 +32,6 @@ mod hash_table; mod sketch; +pub use self::hash_table::ResizeFactor; pub use self::sketch::ThetaSketch; +pub use self::sketch::ThetaSketchBuilder; Review Comment: `ThetaSketchBuilder` and `ResizeFactor` are needed because `ThetaSketch::builder` expose the builder and the builder has a `resize_factor` method that only accepts `ResizeFactor` instance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
