tisonkun commented on code in PR #51: URL: https://github.com/apache/datasketches-rust/pull/51#discussion_r2654651691
########## datasketches/src/frequencies/mod.rs: ########## @@ -29,7 +29,6 @@ mod serde; mod serialization; mod sketch; -pub use self::serde::ItemsSerde; Review Comment: To @PsiACE, No need `ItemsSerde` if we already implement serde over concrete `FrequentItemsSketch<i64>` and `FrequentItemsSketch<String>`. But the C++ impl does have a Serde abstraction you may investigate in https://github.com/apache/datasketches-cpp/blob/7bb979d3/common/include/serde.hpp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
