ZENOTME commented on code in PR #59: URL: https://github.com/apache/datasketches-rust/pull/59#discussion_r2662116899
########## datasketches/src/lib.rs: ########## @@ -38,8 +38,11 @@ pub mod hll; pub mod tdigest; pub mod theta; +mod binomial_bounds; Review Comment: > Are these symbols shared between sketches? Why do you move it out of the theta module? In cpp, this is a in common and shared by theta sketch and tuple sketch: https://github.com/apache/datasketches-cpp/blob/master/common/include/binomial_bounds.hpp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
