tisonkun commented on code in PR #59: URL: https://github.com/apache/datasketches-rust/pull/59#discussion_r2662232804
########## datasketches/src/lib.rs: ########## @@ -38,8 +38,11 @@ pub mod hll; pub mod tdigest; pub mod theta; +mod binomial_bounds; Review Comment: I'm considering add a `pub mod common;` and put all these shared structs under that namespace. But I really _hate_ the name `common` so any alternative can help a lot 🤣 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
