tisonkun commented on code in PR #59: URL: https://github.com/apache/datasketches-rust/pull/59#discussion_r2663243431
########## datasketches/src/lib.rs: ########## @@ -38,8 +38,11 @@ pub mod hll; pub mod tdigest; pub mod theta; +mod binomial_bounds; Review Comment: > However, keep in mind that making arbitrary changes in naming will make it harder for folks to examine how something is implemented across languages, which will make any troubleshooting more difficult as well. This sounds reasonable. Then I tend to move `ResizeFactor` and `NumStdDev` to `pub mod common`; rename `binomial_bounds` as `thetacommon` and decide what should be `pub` for `thetacommon` later. PS. One advantage Rust has is that we can freely decide what symbols should be exported, while Java has less flexibility, so we can see internal impls like `MurmurHash3` must be public (modules may help, but that looks a bit complicated, and users still don't get used to it.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
