Fengzdadi commented on PR #94: URL: https://github.com/apache/datasketches-go/pull/94#issuecomment-3740657252
@proost Thanks for the review feedback! I've made the following updates: 1. ✅ Renamed `ToByteArray` → [ToSlice](cci:1://file:///d:/Code/Projects/apache/datasketches-go/sampling/reservoir_items_sketch.go:124:0-161:1) for naming consistency with `NewReservoirItemsSketchFromSlice` 2. ✅ Added Java compatibility tests `TestReservoirItemsSketch_JavaCompat` with 36 test cases matching the files from your Java PR https://github.com/apache/datasketches-java/pull/714 The tests currently skip (file not found) because the Java-generated `.sk` files haven't been synced to the Go repo yet. Once they're available, the tests will automatically run and validate cross-language compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
