ariesdevil commented on code in PR #329: URL: https://github.com/apache/datasketches-rust/pull/329#discussion_r4489391582
########## datasketches/src/xor/mod.rs: ########## @@ -22,16 +22,15 @@ //! performs exactly three fingerprint reads per query. Construction needs temporary space linear //! in the number of distinct hashes. Review Comment: Could we clarify which part of construction this space bound applies to? `XorFilterBuilder` stores one `u64` per input until `build()` deduplicates the hashes. Passing one million copies of the same hash to `update_hashes` allocated 8,000,000 bytes just to collect them. I’d suggest saying that the builder buffers one hash per input and that, after deduplication, constructing the layout needs additional space proportional to the number of distinct hashes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
