tisonkun commented on code in PR #329: URL: https://github.com/apache/datasketches-rust/pull/329#discussion_r4490374706
########## datasketches/src/xor/mod.rs: ########## @@ -22,16 +22,15 @@ //! performs exactly three fingerprint reads per query. Construction needs temporary space linear //! in the number of distinct hashes. Review Comment: We may also use a hashset to collect hashes. I'd leave it as an internal improvement. Perhaps we should hide this details from user documents. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
