seelmann commented on code in PR #37:
URL: https://github.com/apache/directory-studio/pull/37#discussion_r895208407
##########
pom.xml:
##########
@@ -137,8 +139,8 @@
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-compiler-plugin</artifactId>
<configuration>
- <source>1.8</source>
- <target>1.8</target>
+ <source>11</source>
+ <target>11</target>
Review Comment:
Thanks!
##########
plugins/ldapbrowser.core/src/main/java/org/apache/directory/studio/ldapbrowser/core/jobs/ExportOdfRunnable.java:
##########
@@ -60,6 +61,9 @@ public class ExportOdfRunnable implements
StudioConnectionRunnableWithProgress
/** The maximum count limit */
public static final int MAX_COUNT_LIMIT = 65000;
+ /** The postal address decoder. */
+ private static CharSequenceTranslator DECODER =
Utils.createPostalAddressDecoder( "\n" ); //$NON-NLS-1$;
Review Comment:
According to the javadoc all translators are thread-safe so the singleton is
fine.
##########
plugins/valueeditors/pom-first.xml:
##########
@@ -64,10 +64,12 @@
org.apache.directory.studio.valueeditors.uuid</Export-Package>
<Import-Package>org.apache.commons.codec,
- org.apache.commons.codec.binary
+ org.apache.commons.codec.binary,
+ org.apache.commons.text
</Import-Package>
<Require-Bundle>
+ org.apache.commons.commons-text,
Review Comment:
Is the bundle required if the package is imported, or vice versa?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
