roubert commented on code in PR #37:
URL: https://github.com/apache/directory-studio/pull/37#discussion_r895209532


##########
plugins/valueeditors/pom-first.xml:
##########
@@ -64,10 +64,12 @@
  org.apache.directory.studio.valueeditors.uuid</Export-Package>
  
             <Import-Package>org.apache.commons.codec,
- org.apache.commons.codec.binary
+ org.apache.commons.codec.binary,
+ org.apache.commons.text
             </Import-Package>
             
             <Require-Bundle>
+ org.apache.commons.commons-text,

Review Comment:
   I don't really understand how these dependency declarations work so what's 
here is all the result of trial-and-error (but the result is that both 
`build.sh` and Eclipse can build and run this the way it is now). If you or 
someone else actually knows how this really works, you might want to take a 
look afterwards and see if you can find things to correct or simplify.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to