seelmann commented on code in PR #37:
URL: https://github.com/apache/directory-studio/pull/37#discussion_r895212780
##########
plugins/valueeditors/pom-first.xml:
##########
@@ -64,10 +64,12 @@
org.apache.directory.studio.valueeditors.uuid</Export-Package>
<Import-Package>org.apache.commons.codec,
- org.apache.commons.codec.binary
+ org.apache.commons.codec.binary,
+ org.apache.commons.text
</Import-Package>
<Require-Bundle>
+ org.apache.commons.commons-text,
Review Comment:
`Require-Bundle` means to use that specific bundle/dependency, and all
packages in that bundle are imported.
`Import-Package` means to only import the declared packages, so it's more
fine-grained. The actual implementation of the packagesis open at the
`MANIFEST.MF` level. The pb is also that those declarations are not transitive,
so I assume we need to import `org.apache.commons.text` and
`org.apache.commons.text.translate`.
Fine to keep it like this, I'll have a look later if we can simplify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
