Sorry, I didn't get the chance to take a look your pull request. There is also a pull request (updating the libthrift version in core) which will touch quite bunch of files. I am trying to figure out a plan for accommodate these two changes. I will try to comment on your pull request.
- Sijie On Wed, Nov 2, 2016 at 2:25 AM, Khurrum Nasim <khurrumnas...@gmail.com> wrote: > Any updates on this? Can we get this change in ASAP? so I can rebase my > branches to the new package namespace. Appreciate any updates. > > - KN > > On Tue, Nov 1, 2016 at 3:19 AM, Sijie Guo <si...@apache.org> wrote: > > > Khurrum, > > > > thank your so much for making this change. I will try to take a look and > > get back to you soon. > > > > - Sijie > > > > On Fri, Oct 21, 2016 at 2:41 AM, Khurrum Nasim <khurrumnas...@gmail.com> > > wrote: > > > > > Forgot the pull request - > > > https://github.com/apache/incubator-distributedlog/pull/41 > > > > > > - KN > > > > > > On Fri, Oct 21, 2016 at 2:41 AM, Khurrum Nasim < > khurrumnas...@gmail.com> > > > wrote: > > > > > > > I just sent a pull request - repacked the package from > > > > com.twitter.distributedlog to org.apache.distributedlog. > > > > > > > > (basically just renamed files and sed/replace the package name) > > > > > > > > Let me know if it is okay. > > > > > > > > - KN > > > > > > > > On Sat, Oct 8, 2016 at 6:55 AM, Sijie Guo <si...@apache.org> wrote: > > > > > > > >> Khurrum, I don't think anyone is working on this now. Feel free to > > pick > > > it > > > >> up. > > > >> > > > >> - Sijie > > > >> > > > >> On Fri, Oct 7, 2016 at 10:37 AM, Khurrum Nasim < > > khurrumnas...@gmail.com > > > > > > > >> wrote: > > > >> > > > >> > Is anyone working on repackaging? If no, can I pick this up? > > > >> > > > > >> > - KN > > > >> > > > > >> > On Sat, Sep 17, 2016 at 10:27 PM, Khurrum Nasim < > > > >> khurrumnas...@gmail.com> > > > >> > wrote: > > > >> > > > > >> > > +1 > > > >> > > > > > >> > > On Mon, Sep 12, 2016 at 6:16 PM, Stevo Slavić < > ssla...@gmail.com> > > > >> wrote: > > > >> > > > > > >> > >> + 1 (non-binding) for doing it asap > > > >> > >> > > > >> > >> On Mon, Sep 12, 2016 at 11:40 AM, Flavio Junqueira < > > f...@apache.org > > > > > > > >> > >> wrote: > > > >> > >> > > > >> > >> > It isn't strictly necessary, here is what the documentation > > says: > > > >> > >> > > > > >> > >> > On Repackaging > > > >> > >> > > > > >> > >> > It is recommended - but not mandated - that source is > > repackaged > > > >> under > > > >> > >> the > > > >> > >> > Apache namespace. There is no need to use the incubator > > > namespace. > > > >> For > > > >> > >> > example, Java source might be repackaged to > org.apache.foo.Bar > > > or a > > > >> > DTD > > > >> > >> to > > > >> > >> > http://dtd.apache.org/foo/bar. > > > >> > >> > > > > >> > >> > Existing open source projects moving to Apache may well need > to > > > >> > consider > > > >> > >> > carefully how they will approach this transition. > > > >> > >> > > > > >> > >> > > > > >> > >> > > > > >> > >> > My suggestion is to repackage before the first release, > though. > > > >> This > > > >> > way > > > >> > >> > applications written against the early release will have the > > > right > > > >> > >> > namespace already. > > > >> > >> > > > > >> > >> > -Flavio > > > >> > >> > > > > >> > >> > > On 10 Sep 2016, at 20:32, Sijie Guo <si...@apache.org> > > wrote: > > > >> > >> > > > > > >> > >> > > Any suggestions from mentors for the first release? > > > >> > >> > > > > > >> > >> > > - Sijie > > > >> > >> > > > > > >> > >> > > On Tue, Aug 30, 2016 at 11:18 PM, Sijie Guo < > > si...@apache.org> > > > >> > wrote: > > > >> > >> > > > > > >> > >> > >> Does anyone know if it is required to repackage the > > namespace > > > to > > > >> > >> under > > > >> > >> > >> org.apache for the first release? Any suggestions from > > > mentors? > > > >> > >> > >> > > > >> > >> > >> - Sijie > > > >> > >> > >> > > > >> > >> > > > > >> > >> > > > > >> > >> > > > >> > > > > > >> > > > > > >> > > > > >> > > > > > > > > > > > > > >
