Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984456
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/BKAsyncLogReader.java
---
@@ -381,16 +369,16 @@ public String getStreamName() {
* @return A promise that when satisfied will contain the Log Record
with its DLSN.
*/
@Override
- public synchronized Future<LogRecordWithDLSN> readNext() {
- return readInternal(1, 0,
TimeUnit.MILLISECONDS).map(READ_NEXT_MAP_FUNCTION);
+ public synchronized CompletableFuture<LogRecordWithDLSN> readNext() {
+ return readInternal(1, 0,
TimeUnit.MILLISECONDS).thenApply(READ_NEXT_MAP_FUNCTION);
}
- public synchronized Future<List<LogRecordWithDLSN>> readBulk(int
numEntries) {
+ public synchronized CompletableFuture<List<LogRecordWithDLSN>>
readBulk(int numEntries) {
return readInternal(numEntries, 0, TimeUnit.MILLISECONDS);
}
@Override
- public synchronized Future<List<LogRecordWithDLSN>> readBulk(int
numEntries,
+ public synchronized CompletableFuture<List<LogRecordWithDLSN>>
readBulk(int numEntries,
long
waitTime,
--- End diff --
Please also do the code alignment change here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
