Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984676
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/BKLogWriteHandler.java
---
@@ -483,23 +482,23 @@ protected long assignLogSegmentSequenceNumber()
throws IOException {
}
protected BKLogSegmentWriter doStartLogSegment(long txId, boolean
bestEffort, boolean allowMaxTxID) throws IOException {
- return FutureUtils.result(asyncStartLogSegment(txId, bestEffort,
allowMaxTxID));
+ return Utils.ioResult(asyncStartLogSegment(txId, bestEffort,
allowMaxTxID));
}
- protected Future<BKLogSegmentWriter> asyncStartLogSegment(final long
txId,
+ protected CompletableFuture<BKLogSegmentWriter>
asyncStartLogSegment(final long txId,
final
boolean bestEffort,
--- End diff --
Please also do the code alignment change here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
