Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984772
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/impl/logsegment/BKLogSegmentEntryStore.java
---
@@ -186,13 +185,13 @@ LedgerAllocator
createLedgerAllocator(LogMetadataForWriter logMetadata,
//
@Override
- public Future<LogSegmentEntryReader> openReader(LogSegmentMetadata
segment,
+ public CompletableFuture<LogSegmentEntryReader>
openReader(LogSegmentMetadata segment,
long startEntryId) {
--- End diff --
Please also do the code alignment change here, also at line 244.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
