?, This suggestion seems to have nothing to do with the content of the discussion
-------------------- DolphinScheduler(Incubator) Commtter Hemin Wen 温合民 [email protected] -------------------- haoy0227 <[email protected]> 于2020年11月30日周一 下午9:29写道： > 什么时候添加一个全部定时管理界面，这样更加方便。 > > > | | > haoy0227 > | > | > [email protected] > | > 签名由网易邮箱大师定制 > On 11/30/2020 19:36，Hemin Wen<[email protected]> wrote： > "modify code in production environment” > > yes, I also considered based on this, I think the workflow definition > should not be changed from the workflow instance. > > If it is test, it should be in the test environment. > If it is the final change to the workflow definition, then the workflow > definition should be modified. > > And this is a low frequency operation, No version recorded, No need to > introduce a changed version. > > — > > "在生产环境修改代码” > > 是的，我也是基于此考虑的，我认为不应该通过修改工作流实例去变更工作流定义. > > 如果是测试，应该在测试环境，或者建立一个临时测试工作流 > 如果是最终要变更工作流定义，那应该直接修改工作流定义(可以提供一种不下线变更入口) > > 并且这是一个低频操作，没有版本记录，这里也没必要再引入一个变更版本管理 > > > -------------------- > DolphinScheduler(Incubator) Commtter > Hemin Wen 温合民 > [email protected] > -------------------- > > > leon bao <[email protected]> 于2020年11月30日周一 下午7:17写道： > > Is there such a situation, i need re-run the workflow that needed to adjust > the parameters some days ago, but this adjustment does not affect the > online normal data execution process. > > However, your email reminds me of another problem. > The normal update of workflow definition may require a series of actions: > "offline workflow - modify workflow - Online workflow" > - Maybe not only these actions, but also some permission applications for > changes. > - Updating the workflow definition in production directly from the workflow > instance, that is equivalent to "modify code in production environment". Is > there any risk? > > > > > ====================================================================================== > > 1. 是否有这样的情况，几天前的工作流需要调整参数，然后重跑，但是这个调整不影响线上正常数据的执行流程 > > 2. 但是你的邮件让我想到另外一个问题，正常更新工作流定义的动作是有可能需要一连串的动作： > “下线工作流-修改工作流-上线工作流” > -- 可能不止这些，还有一些工作流定义修改的权限申请等等。 > -- 直接从工作流实例里面更新生产上的工作流定义，相当于"在生产环境修改代码"，是否有一些风险？ > > > > Hemin Wen <[email protected]> 于2020年11月30日周一 下午1:59写道： > > Got it. > > > -------------------- > DolphinScheduler(Incubator) Commtter > Hemin Wen 温合民 > [email protected] > -------------------- > > > boyi <[email protected]> 于2020年11月30日周一 上午11:51写道： > > hi: > > > > > Workflow instances support re-runs, you can debug online problems based > on > snapshots, and after troubleshooting, update to the workflow definition > to > avoid problems next time. > > > ——————— > > > 工作流实例支持重跑, 可以根据快照 debug线上问题,排除掉之后.更新到工作流定义里面.避免下次在出问题. > > > -------------------------------------- > BoYi ZhangE-mail : [email protected] > On 11/30/2020 11:48，Hemin Wen<[email protected]> wrote： > I don’t know which scenarios will modify the workflow instance without > changing the workflow definition. > > > -------------------- > DolphinScheduler(Incubator) Commtter > Hemin Wen 温合民 > [email protected] > -------------------- > > > boyi <[email protected]> 于2020年11月30日周一 上午11:23写道： > > hi : > > > I think this function is necessary > -------------------------------------- > BoYi ZhangE-mail : [email protected] > On 11/30/2020 10:32，xingchun.chen<[email protected]> wrote： > I think updating the workflow instance can keep the update workflow > definition checkbox. After updating the workflow instance, users can > choose > whether to update the workflow definition instead of manually updating > the > workflow definition again. > > > ------------------ 原始邮件 ------------------ > 发件人: > "dev" > < > [email protected]>; > 发送时间: 2020年11月30日(星期一) 上午10:09 > 收件人: "dev"<[email protected]>; > > 主题: [DISCUSS] About modify workflow instance function > > > > Hi, all! > > Currently, DS supports editing workflow instance while updating > workflow > definition, > You can also choose not to update the workflow definition, there is a > check > box here. > > I guess the reason of this design, Add the entry in the workflow > instance, > Workflow can be updated without offline workflow definition. > > I did not think of a scenario where only the workflow instance is > updated. > Modifying only the workflow instance without updating the definition > will > also lead to inconsistent data. > > So, Is it possible to remove the check box for updating the workflow > definition here? > > -------------------- > DolphinScheduler(Incubator) Commtter > Hemin Wen 温合民 > [email protected] > -------------------- > > > > > -- > DolphinScheduler(Incubator) PPMC > BaoLiang 鲍亮 > [email protected] > >
