I think it's neccesary to keep this function.

1.If we need update the proress definition,If upate the process definiton 
direcly,we need change it's state from online to offline,and when we 
modified,need change it's state from offline to online.
So  I think it's easy-to-use to keep the function, when update the process 
instance support the choise whether decide to update the process definition.

2.It's have another benefit,we can test the process instance first,if it runs 
successful,then we can decide to update the process definition directly.

Of course,we can enhance this function with permission controler,Such as only 
someone who have permission can update the process definiton by update the 
process instance.



Best Regards

DolphinScheduler(Incubator) PPMC
Gang Li 李岗

[email protected]
 
From: Hemin Wen
Date: 2020-11-30 10:09
To: dev
Subject: [DISCUSS] About modify workflow instance function
Hi, all!
 
Currently, DS supports editing workflow instance while updating workflow
definition,
You can also choose not to update the workflow definition, there is a check
box here.
 
I guess the reason of this design, Add the entry in the workflow instance,
Workflow can be updated without offline workflow definition.
 
I did not think of a scenario where only the workflow instance is updated.
Modifying only the workflow instance without updating the definition will
also lead to inconsistent data.
 
So, Is it possible to remove the check box for updating the workflow
definition here?
 
--------------------
DolphinScheduler(Incubator) Commtter
Hemin Wen  温合民
[email protected]
--------------------

Reply via email to