imay commented on a change in pull request #368: Add a frontend interface for
committing RoutineLoadTask
URL: https://github.com/apache/incubator-doris/pull/368#discussion_r237431774
##########
File path: gensrc/thrift/FrontendService.thrift
##########
@@ -531,6 +531,22 @@ struct TLoadTxnRollbackResult {
1: required Status.TStatus status
}
+struct TRLTaskCommitRequest {
Review comment:
I think you should put this request to `TLoadTxnCommitRequest` as an
optional field. Then you needn't define a new RPC interface. In addition, if
you add new type of RLTask, you just add new option field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
