imay commented on a change in pull request #368: Add a frontend interface for
committing RoutineLoadTask
URL: https://github.com/apache/incubator-doris/pull/368#discussion_r238921544
##########
File path: fe/src/main/java/org/apache/doris/transaction/TransactionState.java
##########
@@ -334,8 +355,28 @@ public LoadJobSourceType getSourceType() {
public boolean isPublishTimeout() {
// timeout is between 3 to Config.max_txn_publish_waiting_time_ms
seconds.
long timeoutMillis = Math.min(Config.publish_version_timeout_second *
publishVersionTasks.size() * 1000,
- Config.load_straggler_wait_second *
1000);
+ Config.load_straggler_wait_second * 1000);
timeoutMillis = Math.max(timeoutMillis, 3000);
return System.currentTimeMillis() - publishVersionTime > timeoutMillis;
}
+
+ public void setCallBack(TransactionCallBack callBack) {
+ this.callBack = callBack;
+ }
+
+ public TransactionCallBack getCallBack() {
+ return callBack;
+ }
+
+ private TransactionStateExtra readTxnStateExtra(DataInput in) throws
IOException {
Review comment:
This should to be a static function in `TransactionStateExtra`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
